cli: Warn on sizes above 10MB during solana rent
#922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
reviewed
Apr 19, 2024
kubanemil
force-pushed
the
rent_limit_cli
branch
from
5e83cb9 to
5a9eaa2
Compare
joncinque
reviewed
Apr 19, 2024
cli/src/cluster_query.rs
Outdated
| @@ -2181,6 +2181,9 @@ pub fn process_calculate_rent( | |||
| data_length: usize, | |||
| use_lamports_unit: bool, | |||
| ) -> ProcessResult { | |||
| if data_length > 10_000_000 { | |||
There was a problem hiding this comment.
Can you use
instead of this value?
kubanemil
force-pushed
the
rent_limit_cli
branch
from
697f084 to
6494121
Compare
kubanemil
force-pushed
the
rent_limit_cli
branch
from
6494121 to
608e9b6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #922 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 853 853
Lines 231812 231814 +2
=========================================
Hits 189867 189867
- Misses 41945 41947 +2 |
joncinque
changed the title
solana rent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CLI command
$ solana rent <DATA_LENGTH_OR_MONIKER>calculates the rent even if DATA_LENGTH is greater than 10 MB - which is the maximum size for a single account. The CLI tool should give a warning to avoid misleading the user.Summary of Changes
Added the check for it.